Skip to content

Conversation

aspeddro
Copy link
Contributor

@aspeddro aspeddro commented Jan 31, 2023

  • Remove the bs. prefix
  • Add extension name to the message

@aspeddro
Copy link
Contributor Author

I'm still going to add tests.

Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.
I think there's no need to add automatic tests, as long as each case is tested at each once manually. Unless you think this might regress in future.

Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge after a tiny change.

Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cristianoc cristianoc merged commit abb5822 into rescript-lang:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants