Skip to content

WIP: ocamlformat 0.26.0 #6360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Aug 20, 2023

Upgrade ocamlformat from 0.22.4 to 0.26.0 because

  • it seems the old version conflicts with the latest ocaml-lsp-server
  • the (few) formatting changes actually look like improvements

@cknitt cknitt changed the title ocamlformat 0.26.0 WIP: ocamlformat 0.26.0 Aug 20, 2023
@cknitt cknitt added this to the v12 milestone Aug 20, 2023
@cknitt
Copy link
Member Author

cknitt commented Aug 20, 2023

Seems that won't work because the new version is not in the OPAM repository used for Windows yet.

@cristianoc
Copy link
Collaborator

Seems that won't work because the new version is not in the OPAM repository used for Windows yet.

How about holding for a while then merge when ready.

@cknitt
Copy link
Member Author

cknitt commented Feb 1, 2024

Superseded by #6493.

@cknitt cknitt closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants