Skip to content

Deprecate JSX 3 #7042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Deprecate JSX 3 #7042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2983e34
deprecate jsx 3 from bsb
mununki Sep 19, 2024
5828322
clean up
mununki Sep 19, 2024
9473874
changelog
mununki Sep 19, 2024
5875abf
fix changelog
mununki Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
> - :house: [Internal]
> - :nail_care: [Polish]

# 11.1.5 (Unreleased)

- Deprecate JSX 3 https://github.com/rescript-lang/rescript-compiler/pull/7042

# 11.1.4

- Fix issue where long layout break added a trailing comma in partial application `...`. https://github.com/rescript-lang/rescript-compiler/pull/6949
Expand Down
8 changes: 7 additions & 1 deletion jscomp/bsb/bsb_jsx.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,13 @@ let from_map map =
match m.?(Bsb_build_schemas.jsx_version) with
| Some (Flo { loc; flo }) -> (
match flo with
| "3" -> version := Some Jsx_v3
| "3" ->
let loc_end =
{loc with Lexing.pos_cnum = loc.Lexing.pos_cnum + 1}
in
let loc = {Warnings.loc_start = loc; loc_end; loc_ghost = false} in
Location.deprecated loc "jsx 3 is deprecated, use jsx 4 instead";
version := Some Jsx_v3
| "4" -> version := Some Jsx_v4
| _ -> Bsb_exception.errorf ~loc "Unsupported jsx version %s" flo
)
Expand Down