Skip to content

Better error when defining a type inside of a function #7843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 5, 2025
Merged

Better error when defining a type inside of a function #7843

merged 5 commits into from
Sep 5, 2025

Conversation

zth
Copy link
Member

@zth zth commented Sep 5, 2025

No description provided.

@zth zth requested review from cknitt, tsnobip and mediremi September 5, 2025 09:26
mediremi
mediremi approved these changes Sep 5, 2025
View reviewed changes
Copy link
Member

@mediremi mediremi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! ✨

nojaf
nojaf approved these changes Sep 5, 2025
View reviewed changes
Copy link
Member

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 5, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7843

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7843

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7843

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7843

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7843

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@7843

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7843

commit: 5668baf

@zth zth merged commit ed425d8 into master Sep 5, 2025
25 checks passed
@zth zth deleted the type-def-in-fn-error branch September 5, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsnobip tsnobip tsnobip approved these changes

@nojaf nojaf nojaf approved these changes

@mediremi mediremi mediremi approved these changes

@cknitt cknitt Awaiting requested review from cknitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zth @tsnobip @nojaf @mediremi