Stdlib: add DataView with littleEndian get/set

[htoooth]

No description provided.

[pkg-pr-new]

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7881

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7881

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7881

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7881

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7881

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@7881

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7881

commit: f9c494b

[cknitt]

@htoooth Thank you for your contribution! 👍

Instead of two bindings per function like

@send external getInt16: (t, int) => int = "getInt16"
@send external getInt16LittleEndian: (t, int, @as(1) _) => int = "getInt16"

could you do single bindings like

@send external getInt16: (t, int, ~littleEndian: bool=?) => int = "getInt16"

please?

(Bonus points for adding doc strings with tests/code examples 🙂.)

[htoooth]

@cknitt

1. I did it this way because I saw that's how it was done in the previous v11.
2. The idea of encapsulating polymorphic functions mentioned in the document is also to encapsulate for different situations.
3. This makes it easier to migrate old code.

By the way, I also initially thought of adding a parameter like your said @cknitt

Where to add tests and documentation? I couldn't find the previous documents and test cases

[cometkim]

Using @as(1) _ here is neat btw

[cknitt]

I did it this way because I saw that's how it was done in the previous v11.

In previous ReScript versions, the approach with the optional argument was not really ergonomic because a trailing unit argument was required.

Now that it has become feasible, we have moved to single bindings in the stdlib where possible, as this is much clearer to JS devs, basically resulting in a 1:1 correspondence with the JS APIs as documented on MDN.

E.g. Float.toString with optional parameter radix, deprecating Float.toStringWithRadix. There are many more such examples in the new stdlib.

Therefore, also the DataView bindings should follow suit.

Docstrings are in a corresponding .resi file and contain examples that are automatically verified as test assertions during the CI build.

Example:

rescript/packages/@rescript/runtime/Stdlib_Float.resi

Line 363 in 67742d5

`toString(v)` return a `string` representing the given value.

[htoooth]

@cknitt I have made the revisions and added the doc.