Very basic implementation of for..of loops #7887
Draft
+554
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cknitt
commented
Sep 13, 2025
| @@ -450,6 +450,9 @@ module E = struct | |||
| | Pexp_for (p, e1, e2, d, e3) -> | |||
| for_ ~loc ~attrs (sub.pat sub p) (sub.expr sub e1) (sub.expr sub e2) d | |||
| (sub.expr sub e3) | |||
| | Pexp_for_of (_pat, _array_expr, _body_expr) -> | |||
| (* Convert for...of to an extension since it doesn't exist in old AST *) | |||
| extension ~loc ~attrs (Location.mkloc "rescript.for_of" loc, PStr []) | |||
There was a problem hiding this comment.
Not sure what needs to be done here.
How can we map to ast0 in such a way that we can map it back?
cknitt
commented
Sep 13, 2025
|
|
||
| 1 │ for x | ||
| 2 │ | ||
|
|
||
| Did you forget a `in` here? | ||
| I'm not sure what to parse here when looking at "eof". |
There was a problem hiding this comment.
Not sure what to do about this change in the test output here
| 5 │ Js.log("for") | ||
| 6 │ } | ||
|
|
||
| consecutive statements on a line must be separated by ';' or a newline |
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My assistant and I created a very basic implementation of for...of loops that only works on arrays for now.
Will need to think about how to support iterators later.