Skip to content

Feature Request: Verbose Command Output #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bushuo opened this issue Oct 18, 2024 · 3 comments
Closed

Feature Request: Verbose Command Output #137

Bushuo opened this issue Oct 18, 2024 · 3 comments

Comments

@Bushuo
Copy link
Collaborator

Bushuo commented Oct 18, 2024

While working on #102, I found it helpful to see the output of bsc. I think it would be a great addition to have a command line flag in Rewatch that allows users to view the output of the underlying commands, something like:

rewatch build --verbose

I'd be happy to submit a PR for this if you're open to it.

@rolandpeelen
Copy link
Member

@Bushuo - A PR would be super welcome here. I've done some work here to move to env:logger but my time is slipping away from me. Perhaps you can take that as a starting point and implement @cknitt 's comment to instantiate the logger from an argument rather than from env?

@rolandpeelen
Copy link
Member

Done here: #126

-- We should add some debug / trace logs throughout the code for better verbosity, including for instance the commands we're running to bsc. I have some thoughts on restructuring a thing or two to make this better, including error handling. Consider it a work in progress.

Closing this for now - Feel free to open a PR if you see a place you'd like some trace output :)

@Bushuo
Copy link
Collaborator Author

Bushuo commented Nov 18, 2024

@rolandpeelen - Thanks for picking this back up. I unfortunately did not have time for this the last weeks. I will take a look at your PR and maybe provide a PR myself for logging the commands to bsc that you mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants