fix(react-email): Missing URLSearchParams on global context for email VM #1419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
As we need to pre-import the modules from Node into the app before loading them with vm
we also need to define the context in which the code will run for us to get the email's component,
this means that we need to pass in a few other global things like Buffer that the global
dynamically doesn't contain.
What was the issue?
That being said, something that was missing from the global context was the URLSearchParams class,
which this PR adds. Similar to #1232.
How can I test to make sure it's fixed?
npx tsx ../../packages/react-email/src/cli/index.ts dev
inside of./apps/demo
./apps/demo/emails/airbnb-review.tsx
by adding the following:URLSearchParams is not defined