Skip to content

Conversation

ugurrdemirel
Copy link
Contributor

Hello, I noticed Headers doesn't in the get-email-component.ts. Because of this, you can't see the preview of your email template if you are using Headers in your code. This PR should fix it.

(BTW I spent 4 hours while investigating why tf is this can't find Headers 🤣)

Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-email-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 0:11am

Copy link

vercel bot commented May 3, 2024

@ugurrdemirel is attempting to deploy a commit to the resend Team on Vercel.

A member of the Team first needs to authorize it.

@ugurrdemirel ugurrdemirel changed the title added headers api at preview feat(react-email): Added Headers api May 3, 2024
@gabrielmfern gabrielmfern changed the title feat(react-email): Added Headers api fix(react-email): Missing Headers on the global context for email templates May 3, 2024
@gabrielmfern
Copy link
Member

Can you also format?

@gabrielmfern gabrielmfern added the Package: react-email This is the CLI we generally use as just `email` on the temrinal. label May 3, 2024
@ugurrdemirel
Copy link
Contributor Author

image

I sent one more commit to format it. It shows ok when I run format:check but don't know why gh actions shows like this

@@ -7876,8 +7876,8 @@ export { Prism };
return "string" == typeof e
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be failing formatting check due to the changes here, were they done by prettier? IIRC this file should be ignored.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, prettier made changes at this file when I run format

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weirdly, if I do format on my machine, it changes this file back to what it was before. It might be a Unix-Windows thing, not sure, adding it to a .prettierignore either way.

@gabrielmfern gabrielmfern merged commit 8f0ca7f into resend:canary May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: react-email This is the CLI we generally use as just `email` on the temrinal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants