-
Notifications
You must be signed in to change notification settings - Fork 763
fix(docs): Logical sequence for internal components #1845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
changed internal components sequence to be more logical and easy to follow.
🦋 Changeset detectedLatest commit: 2752aac The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@Sonkaryasshu is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
Why is this easier to follow exactly? |
The updated sequence groups related components logically, making it easier to locate and understand their context. For instance:
This organization reduces cognitive load by reflecting the natural flow of creating email layouts, making the docs more intuitive and efficient to use. |
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: gabriel miranda <[email protected]>
81c08e3
to
301f54b
Compare
a30b3fd
to
5f1828b
Compare
process.env = { | ||
...process.env, | ||
NODE_ENV: 'development', | ||
...(process.env as Omit<NodeJS.ProcessEnv, 'NODE_ENV'> & { | ||
NODE_ENV?: NodeJS.ProcessEnv['NODE_ENV']; | ||
}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation doesn't respect the user's NODE_ENV as the changeset suggests. It explicitly sets NODE_ENV: 'development'
first, then spreads the rest of the environment variables, which means any user-defined NODE_ENV will be overwritten.
To properly respect the user's environment, consider this approach instead:
process.env = {
...process.env,
NODE_ENV: process.env.NODE_ENV || 'development',
}
This preserves the user's NODE_ENV if set, while defaulting to 'development' only when not specified.
process.env = { | |
...process.env, | |
NODE_ENV: 'development', | |
...(process.env as Omit<NodeJS.ProcessEnv, 'NODE_ENV'> & { | |
NODE_ENV?: NodeJS.ProcessEnv['NODE_ENV']; | |
}), | |
process.env = { | |
...process.env, | |
NODE_ENV: process.env.NODE_ENV || 'development', | |
} |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
changed internal components sequence to be more logical and easy to follow.