-
Notifications
You must be signed in to change notification settings - Fork 766
feat(render): Integration test for vite and nextjs #2176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gabrielmfern
wants to merge
81
commits into
canary
Choose a base branch
from
feature/react-22-make-integration-test-for-render
base: canary
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(render): Integration test for vite and nextjs #2176
gabrielmfern
wants to merge
81
commits into
canary
from
feature/react-22-make-integration-test-for-render
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a134dc1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0f8ec1b
to
1442a04
Compare
1442a04
to
b8e1638
Compare
6c573e4
to
a134dc1
Compare
61d045a
to
cee3eec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in a new directory and test file, following the same lines of what we already have with Tailwind. The biggest difference is that the test this PR adds also tests things from the browser with playwright and tries to ensure they don't error during render.
It currently tests with the following:
vite
in the browsernextjs
in the browsernextjs
in a node api routenextjs
in a edge api routeWhere all of them are ran both in dev and in production to make sure it works the same
The
test
CI is failing exactly because there are two current issues withrender
, #1630 and #1953.