Skip to content

feat(render): Integration test for vite and nextjs #2176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 81 commits into
base: canary
Choose a base branch
from

Conversation

gabrielmfern
Copy link
Collaborator

@gabrielmfern gabrielmfern commented Apr 21, 2025

This PR adds in a new directory and test file, following the same lines of what we already have with Tailwind. The biggest difference is that the test this PR adds also tests things from the browser with playwright and tries to ensure they don't error during render.

It currently tests with the following:

  • vite in the browser
  • nextjs in the browser
  • nextjs in a node api route
  • nextjs in a edge api route

Where all of them are ran both in dev and in production to make sure it works the same

The test CI is failing exactly because there are two current issues with render, #1630 and #1953.

Copy link

changeset-bot bot commented Apr 21, 2025

🦋 Changeset detected

Latest commit: a134dc1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@react-email/render Patch
@react-email/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-email ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2025 3:05pm
react-email-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2025 3:05pm

@gabrielmfern gabrielmfern marked this pull request as draft April 21, 2025 17:46
@gabrielmfern gabrielmfern force-pushed the feature/react-22-make-integration-test-for-render branch from 0f8ec1b to 1442a04 Compare April 23, 2025 11:46
@gabrielmfern gabrielmfern force-pushed the feature/react-22-make-integration-test-for-render branch from 1442a04 to b8e1638 Compare April 23, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants