Skip to content

fix memory leak #1506 #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2020
Merged

fix memory leak #1506 #1543

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions src/RestSharp/Http.Async.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,20 +173,29 @@ long CalculateContentLength()
void SetTimeout(IAsyncResult asyncResult)
{
if (Timeout != 0)
ThreadPool.RegisterWaitForSingleObject(
_timeoutState.Handle = ThreadPool.RegisterWaitForSingleObject(
asyncResult.AsyncWaitHandle,
TimeoutCallback, _timeoutState, Timeout, true
);

static void TimeoutCallback(object state, bool timedOut)
{
if (!timedOut)
return;

if (!(state is TimeOutState tos))
return;

lock (tos) tos.TimedOut = true;
lock(tos)
{
if(!timedOut)
{
if(tos.Handle != null)
{
tos.Handle.Unregister(null);
}
return;
}

tos.TimedOut = true;
}

tos.Request?.Abort();
}
Expand Down Expand Up @@ -286,6 +295,8 @@ class TimeOutState
public bool TimedOut { get; set; }

public HttpWebRequest? Request { get; set; }

public RegisteredWaitHandle? Handle { get; set; }
}
}
}