Skip to content

Conversation

alexeyzimarev
Copy link
Member

  • Make RestClient.Options public, read-only
  • Add a RestClient constructor with HttpClient only, which won't be changed in any way by RestSharp

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 12, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 528f692
Status: ✅  Deploy successful!
Preview URL: https://9de8fd71.restsharp.pages.dev

View logs

* Minor warning fix
* Upgrade MinVer
@IanElsinga
Copy link

Thanks, Alexey, I reviewed your changes. The public read-only Options change looks perfect, and thank you for that.
I did not have time, however, to assimilate the whole discussion around the other issue (HttpClient) so I cannot really comment on that at this point.

@alexeyzimarev alexeyzimarev merged commit 17a3532 into dev Mar 13, 2022
@repo-ranger repo-ranger bot deleted the shared-http-client branch March 13, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants