Fix thread safety issues with RestClient when used as a single instance for Authentication and Cookies #1795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is constructed by the user.
…er properties. This means any code attempting to consume RestSharp and use these features needs to update their toolchain to support C# 9.0 or the code will not compile. We still have a lot of developers using Visual Studio 2019, which does not support C# 9.0. While we are migrating to VS2022, it's a process to get everyone moved over. Please change these back to regular setters so they can be used with earlier versions of Visual Studio.
…y will not cross pollinate requests. Make the CookieContainer a property on the request, not the client. Move Authenticator from the client into the request, since it's request specific. Add tests for cookie handling.
This was referenced Mar 16, 2022
kendallb
force-pushed
the
feature/kendallb/thread-safety-and-more
branch
from
aa982e8 to
4dc1299
Compare
…so, as they may vary by request and we do not want folks messing with the shred single instance of RestClient.
…d at the request level, not at the client level. There are many valid reasons to change this on a per request basis if a client is shared.
kendallb
force-pushed
the
feature/kendallb/thread-safety-and-more
branch
from
037fc31 to
16608d1
Compare
… via async not sure how to convert that one).
|
Gonna close this out out and I can cherry pick bits into separate PR's for you and you can merge them. I will rebase this working tree as they get accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the following changes:
Purpose
Fix issues referenced about thread safety with single instance and improve the API to help developers avoid causing those problems.
Checklist