Skip to content

cleanup: Fix parameter naming case inconsistency in RestRequestExtension.cs #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2023
Merged

Conversation

ztl8702
Copy link
Contributor

@ztl8702 ztl8702 commented Dec 18, 2022

Description

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Might be breaking because we are changing a named argument. Existing call sites that uses Named argument might fail to compile.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@dnfadmin
Copy link

dnfadmin commented Dec 18, 2022

CLA assistant check
All CLA requirements met.

@ztl8702 ztl8702 changed the title Fix argument case inconsistency in RestRequestExtension.cs Fix parameter case inconsistency in RestRequestExtension.cs Dec 18, 2022
@ztl8702 ztl8702 changed the title Fix parameter case inconsistency in RestRequestExtension.cs Fix parameter naming case inconsistency in RestRequestExtension.cs Dec 18, 2022
@ztl8702 ztl8702 changed the title Fix parameter naming case inconsistency in RestRequestExtension.cs cleanup: Fix parameter naming case inconsistency in RestRequestExtension.cs Dec 23, 2022
@alexeyzimarev alexeyzimarev merged commit ed0bd11 into restsharp:dev Jan 8, 2023
@ztl8702 ztl8702 deleted the patch-1 branch January 9, 2023 00:44
@ztl8702
Copy link
Contributor Author

ztl8702 commented Jan 9, 2023

thanks

@ztl8702
Copy link
Contributor Author

ztl8702 commented Jan 9, 2023

Lol I have a bad habit of not writing commit messages well.
image

Was assuming the maintainer would squash + modify commit message.

@alexeyzimarev
Copy link
Member

Yeah, I should change the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants