-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Timeout as TimeSpan, Support custom request timeout #2078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@alexeyzimarev ping |
1 similar comment
@alexeyzimarev ping |
I am not merging it because it will break things. Still thinking how to make it available with some transition. |
@alexeyzimarev any news? |
broke typical usage pattern |
I noticed that one and flagged it, but for some reason I didn't think that I will release a fix (the code is already fixed). I think |
Why do you guys keep removing things and break all dependencies that use different versions. |
I think the current approach to use int for timeout is outdated and it generates a lot of errors when you need to remember that these are milliseconds, and you need translate it. Even HttpClient has timeout as TimeSpan.
The presence of "MaxTimeout" also confuses many users. If you want to set a custom timeout for the request, you need to remember which timeout is set for the rest client. Often, when you set a custom timeout for request, it's higher timeout than the default. These are requests for downloading and uploading files. It's rare case when the timeout is specially reduced for a particular request.