Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for the change
#137
Description
As it turned out, all the commands receiving the parameters like
sys.argv[1:]
except the dump command. Because of this, the command ignored the first parameter which is usually the--connect
so the users were not able to connect to their RethinkDB servers.Note
This PR also contains some adjustments for pytest's config. The Unit/integration tests are missing right now for all the commands, but we will need to include them later.
Code examples
Run the script as a python script
python -m rethinkdb dump -c localhost:28015
Run the script as an installed script
rethinkdb-dump -c localhost:28015
References
Related issues in the past: