Skip to content

Add looseversion to setup and update tags to most recent python version #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

lsabi
Copy link
Contributor

@lsabi lsabi commented Nov 20, 2023

Reason for the change
A change to solve the problem of #309

It integrates and surpasses changes introduced by #306

Description
A clear and concise description of what did you changed and why.

Code examples
If applicable, add code examples to help explain your changes.

Checklist

References
Anything else related to the change e.g. documentations, RFCs, etc.

Copy link

codeclimate bot commented Nov 20, 2023

Code Climate has analyzed commit b227a12 and detected 0 issues on this pull request.

View more on Code Climate.

@srh
Copy link
Contributor

srh commented Nov 21, 2023

I really think we should just have looseversion added, and not the 2.7 removal.

The change here would make the last release that claims to support 2.7 fail to install properly.

@lsabi
Copy link
Contributor Author

lsabi commented Nov 27, 2023

@srh

Authors of the PR cannot approve the PR ..do you have the rights to approve it?

@lsabi lsabi merged commit 45c6ea8 into master Nov 29, 2023
@srh
Copy link
Contributor

srh commented Nov 29, 2023

Thank you for the changes @lsabi . Sorry for my lack of responsiveness. I've been traveling and staying in desert motels the past couple of days.

@lsabi lsabi mentioned this pull request Dec 1, 2023
@lsabi lsabi deleted the lsabi-patch-1 branch December 19, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants