Skip to content

feat(bonfire): Replace async-std,async-tungstenite,async-channel. #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Drevoed
Copy link
Contributor

@Drevoed Drevoed commented Oct 13, 2024

This PR tries to modernize the bonfire service.

Async-std is an unmaintained runtime.
image

fastwebsockets is a much faster implementation of websockets standard compared to async-tungstenite.
Possible choice could be tokio-tungstenite, but it is still slower, albeit easier to work with.

Using tokio also allows us to later use much of the useful features, such as out-of-the box tracing integration.

This PR is draft, will mark as ready when benchmarks for bonfire are ready.

Please make sure to check the following tasks before opening and submitting a PR

  • I understand and have followed the contribution guide
  • I have tested my changes locally and they are working as intended

@insertish insertish assigned insertish and unassigned insertish Apr 25, 2025
@insertish insertish self-requested a review April 25, 2025 11:01
@insertish insertish moved this from 🏗 In Progress to 🆕 Untriaged in Pull Request Overview Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 Untriaged
Development

Successfully merging this pull request may close these issues.

2 participants