chore: bump deps #385
Open
chore: bump deps #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure what to do in wait_for_event() in test.rs when the item returns a RedisError. For now opted to just unwrap() since this is a test. jxl_oxide has deprecated Render::image() in favour of Render::stream() Comment out unused redis22 In Rocket, Outcome::Failure has become Outcome::Error to_rfc3339_string() is deprecated in favour of it's equivalent: try_to_rfc3339_string().unwrap() This should be ok because we are calling this method on DateTime::now() Signed-off-by: Pi-Cla <[email protected]>
|
Force pushed to ensure that this builds on Rust 1.77 |
insertish
requested changes
Apr 25, 2025
There was a problem hiding this comment.
LGTM!
Very sorry for late review, I was very busy this month.
Some changes from other team members are now conflicting with yours.
We're now also dropping the 1.77 requirement and actively trying to fix the issue causing the perf. regression so no need to worry about that.
| @@ -101,6 +101,9 @@ impl TestHarness { | |||
|
|
|||
| let mut stream = self.sub.on_message(); | |||
| while let Some(item) = stream.next().await { | |||
| // Not sure what should be done if we get a RedisError | |||
There was a problem hiding this comment.
This is fine, if Redis is having issues then there are fundamental issues with the environment that need to be resolved.
github-project-automation
bot
moved this from 🆕 Untriaged
to 🛑 Changes requested
in Pull Request Overview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what to do in wait_for_event() in test.rs when the item returns a RedisError. For now opted to just unwrap() since this is a test.
jxl_oxide has deprecated Render::image() in favour of Render::stream()
Comment out unused redis22
In Rocket, Outcome::Failure has become Outcome::Error
to_rfc3339_string() is deprecated in favour of it's equivalent: try_to_rfc3339_string().unwrap() This should be ok because we are calling this method on DateTime::now()
Please make sure to check the following tasks before opening and submitting a PR