Skip to content

Cleanup and ignore generated files #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pinotree
Copy link
Contributor

@pinotree pinotree commented Jan 10, 2018

Tidy the repository a bit, and make it more "usable" when working on libcsv.

Removing all the generated files (and making users generate them when needed) avoids mismatches.
Fixes: #25.

@pinotree pinotree force-pushed the autotools-cleanup branch from 94238bd to 1d99a6d Compare March 16, 2020 08:32
@galloviolet
Copy link

Just a heads up to anyone else who has ended up here while looking into libcsv for their own projects: I highly recommend you take the changes from this PR. It removes a huge number of lines of code worth of compiled files that will make your own clone of libcsv much smaller and more reasonable to maintain. Props to @pinotree.

@pinotree pinotree force-pushed the autotools-cleanup branch from 1d99a6d to afdbe53 Compare June 23, 2022 05:46
pinotree added 2 commits June 23, 2022 07:52
All these files are generated by autotools, and thus there is no need
to store them statically in the repository (where they will only pile
up, growing the size of the repository). Also, the mismatch between the
version of autotools on the host vs the ones used to generated the
current files in the repository causes troubles.

Instead, let users (or make dist) generate them all, using a simple
run of autoreconf.  Add them to .gitignore, so there is no risk to
commit them again.

Fixes: rgamble#25
Add to .gitignore all the files that are generated during build/test.
@pinotree pinotree force-pushed the autotools-cleanup branch from afdbe53 to 7554541 Compare June 23, 2022 05:57
@yihuajack
Copy link

Agree, but according to #7 (comment)_, the maintainer is not for autoreconf -fi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'aclocal-1.14' is missing on your system.
3 participants