Skip to content

[Snyk] Upgrade engine.io from 1.6.8 to 1.8.5 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Snyk] Upgrade engine.io from 1.6.8 to 1.8.5 #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f33718
whatspace
riddopic Apr 27, 2016
b8fca8e
fix: upgrade engine.io from 1.6.8 to 1.8.5
snyk-bot Oct 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"test": "gulp test"
},
"dependencies": {
"engine.io": "1.6.8",
"engine.io": "1.8.5",
"socket.io-parser": "2.2.6",
"socket.io-client": "git://github.com/nus-fboa2016-si/socket.io-client#e0580ef4",
"socket.io-adapter": "0.4.0",
Expand Down
5 changes: 3 additions & 2 deletions test/socket.io.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,7 +655,7 @@ describe('socket.io', function(){
});
});
});

it('should not reuse same-namespace connections', function(done){
var srv = http();
var sio = io(srv);
Expand Down Expand Up @@ -746,6 +746,7 @@ describe('socket.io', function(){
}
});


it('should find all clients across namespace rooms', function(done){
var srv = http();
var sio = io(srv);
Expand Down Expand Up @@ -1533,7 +1534,7 @@ describe('socket.io', function(){
});
});
});

it('should see query parameters sent from secondary namespace connections in handshake object', function(done){
var srv = http();
var sio = io(srv);
Expand Down