allow specify snapshot id for fast append #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZENOTME
reviewed
Mar 4, 2025
| commit_uuid: Option<Uuid>, | ||
| key_metadata: Vec<u8>, | ||
| ) -> Result<FastAppendAction<'a>> { | ||
| let snapshot_id = self.generate_unique_snapshot_id(); | ||
| let snapshot_id = if let Some(snapshot_id) = snapshot_id { | ||
| snapshot_id |
There was a problem hiding this comment.
We should ensure the snapshot id is unique in snapshots. Otherwise we should return the error and let client to regenerate it.
fn generate_unique_snapshot_id(&self) -> i64 {
...
let mut snapshot_id = generate_random_id();
while self
.table
.metadata()
.snapshots()
.any(|s| s.snapshot_id() == snapshot_id)
{
snapshot_id = generate_random_id();
}
snapshot_id
}
|
cc @ZENOTME PTAL |
chenzl25
added a commit
that referenced
this pull request
Mar 12, 2025
* allow specify snapshot id for fast append
chenzl25
added a commit
that referenced
this pull request
Mar 12, 2025
* allow specify snapshot id for fast append
chenzl25
added a commit
that referenced
this pull request
Mar 12, 2025
* allow specify snapshot id for fast append (#14) * allow specify snapshot id for fast append * fix tests * fix
xxchan
added a commit
that referenced
this pull request
Mar 25, 2025
Signed-off-by: xxchan <[email protected]>
xxchan
added a commit
that referenced
this pull request
Mar 25, 2025
Signed-off-by: xxchan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fast_appendto resolve iceberg exactly once sink issue feat(sink): introduce exactly once iceberg sink risingwave#19771 (comment)