feat(iceberg): introduce remove snapshot action #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZENOTME
reviewed
Mar 11, 2025
crates/iceberg/src/transaction.rs
Outdated
|
|
||
| /// Finished building the action and apply it to the transaction. | ||
| pub async fn apply(self) -> Result<Transaction<'a>> { | ||
| self.apply_impl().await |
There was a problem hiding this comment.
Looks like we can just put code in apply_impl in this function.🤔
ZENOTME
reviewed
Mar 11, 2025
crates/iceberg/src/transaction.rs
Outdated
| } | ||
|
|
||
| /// Finished building the action and apply it to the transaction. | ||
| pub fn expire_snapshot_id(mut self, expire_snapshot_id: i64) -> Self { |
There was a problem hiding this comment.
Looks like we don't have test for this.
…avelabs/iceberg-rust into li0k/remove_snapshot_0307
…avelabs/iceberg-rust into li0k/remove_snapshot_0307
ZENOTME
approved these changes
Mar 13, 2025
Li0k
added a commit
that referenced
this pull request
Mar 25, 2025
* feat(iceberg): basic remove snapshot * feat(iceberg): introduce new properties for remove snapshots * feat(iceberg): support remove schemas * refactor(iceberg): refactor file org * address comments * refactor(iceberg): refactor and ut * fix(iceberg): fix integration-test
xxchan
added a commit
that referenced
this pull request
Mar 25, 2025
xxchan
pushed a commit
that referenced
this pull request
Mar 25, 2025
* feat(iceberg): basic remove snapshot * feat(iceberg): introduce new properties for remove snapshots * feat(iceberg): support remove schemas * refactor(iceberg): refactor file org * address comments * refactor(iceberg): refactor and ut * fix(iceberg): fix integration-test
xxchan
pushed a commit
that referenced
this pull request
Mar 25, 2025
* feat(iceberg): basic remove snapshot * feat(iceberg): introduce new properties for remove snapshots * feat(iceberg): support remove schemas * refactor(iceberg): refactor file org * address comments * refactor(iceberg): refactor and ut * fix(iceberg): fix integration-test
xxchan
pushed a commit
that referenced
this pull request
Mar 25, 2025
* feat(iceberg): basic remove snapshot * feat(iceberg): introduce new properties for remove snapshots * feat(iceberg): support remove schemas * refactor(iceberg): refactor file org * address comments * refactor(iceberg): refactor and ut * fix(iceberg): fix integration-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the remove snapshot feature to the SDK along with basic tests. Note that currently, RW only relies on the main branch, no other branches or tags are involved.
refer to https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/RemoveSnapshots.java
Note: cleanExpiredMetadata is not currently implemented.