Fix direct dependency versions (aka "making this book live a little longer") #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all: Thank you for the effort you put into this book. I'm currently reading and enjoying it.
(I have read your contributing guidelines, so I'll make this quick and the diff small. Feel free to just ignore this PR.)
Some notebook cells do not work under
numpy > 2.0.0andmatplotlib > 3.7.0.I have fixed the direct dependencies to versions that I have now checked are working on Python 3.11.9 and the notebooks on
master. This way we could get some more years of life out of this awesome book.I know that most people reading the book should be able to fix the issues themselves, but keeping everyone from having to painstakingly go through many versions of dependencies might be worth the effort here.