Feat: Exception handling #267
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fadarrizz
force-pushed
the
exception-handling
branch
from
2e6187b to
4bd1829
Compare
Fadarrizz
force-pushed
the
exception-handling
branch
from
4bd1829 to
3b0e537
Compare
|
There is one problem I'm still solving: throwing the exception when it hasn't been handled. |
|
@ksassnowski I implemented a feature that throws exceptions when they are not handled by any middleware. To achieve this, we need to track whether an exception has been handled, so I decided to wrap exceptions with a I would appreciate it if you could review this and share your feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds exception handling to the downloader and allows middleware to act upon caught exceptions.
Personally, I need this for handling Javascript (Browsershot) exceptions, so I can retry them. In order to act upon thrown exceptions during the request being sent, exception handling is needed at the downloader level.