Skip to content

Fix duration sign handling #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2025
Merged

Fix duration sign handling #7

merged 1 commit into from
Jun 22, 2025

Conversation

robot-head
Copy link
Owner

Summary

  • handle zero sign multiplier as 0
  • interpret sign correctly when adding date durations
  • parse negative durations properly
  • carry sign when creating durations from normalized records

Testing

  • cargo check
  • cargo test -p temporal_rs --lib -- --nocapture (fails: datetime_subtract_hour_overflows, dt_since_basic, duration_max, duration_round_negative, negative_fields_to_string, basic_instant_until, basic_instant_since, since_basic, until_basic, since_rounding)

https://chatgpt.com/codex/tasks/task_e_6858503d5ef88326b55066f8ec216cb2

@robot-head robot-head merged commit 6b9b646 into ms/optimize_duration Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
codex size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@robot-head