Goto speed 0.1 to 1.5 #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commits: [7c067e5] Support goto with custom max speed from 0.1 to 1.5
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for setting a custom max speed for the goto operation by extending the SpeedLevel enum and updating corresponding API methods to include a float speed parameter.
- Updated SpeedLevel.kt to include a customSpeed() method and floatSpeedLevel property.
- Modified Robot.kt and AIDL definitions to pass the custom float speed value for goto operations.
- Updated sample code and version number.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/src/main/java/com/robotemi/sdk/navigation/model/SpeedLevel.kt | Added customSpeed() function and floatSpeedLevel property to support custom speeds. |
| sdk/src/main/java/com/robotemi/sdk/Robot.kt | Updated goto and goToPosition calls to include the custom float speed parameter. |
| sdk/src/main/aidl/com/robotemi/sdk/ISdkService.aidl | Modified the goTo and goToPosition method signatures to add the new float parameter. |
| sample/src/main/java/com/robotemi/sdk/sample/TemiBroadcastReceiver.kt | Updated sample commands to utilize the new custom speed functionality. |
| gradle.properties | Bumped version number to reflect the new changes. |
cyrus-rbc
approved these changes
May 13, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support goto with custom max speed from 0.1 to 1.5