Skip to content

'Set Selenium Timeout' does not pass timeout variable to selenium #19

@emanlove

Description

@emanlove

It appears the 'Set Selenium Timeout' keyword does not actually set the timeout. The code as currently written

    def set_selenium_timeout(self, seconds):
        # . . .
        old_timeout = self.get_selenium_timeout()
        self._timeout_in_secs = robot.utils.timestr_to_secs(seconds)
        return old_timeout

    def set_selenium_implicit_wait(self, seconds):
# . . .

and the code as I suspect it should be

    def set_selenium_timeout(self, seconds):
        # . . .
        old_timeout = self.get_selenium_timeout()
        self._timeout_in_secs = robot.utils.timestr_to_secs(seconds)
        for browser in self._cache.browsers:
            browser.set_script_timeout(self._timeout_in_secs)
        return old_timeout

    def set_selenium_implicit_wait(self, seconds):
# . . .

Also it appears this feature is untested within the rf-s2l acceptance tests.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions