first steps at testing as-installed opencv #63

bollwyvl · 2020-01-11T03:27:49Z

While looking into the built installer locally, I'm also kicking the tires on testing the OpenCV example notebook.

datakurre · 2020-01-11T06:32:23Z

Thanks. Anything that successfully imports cv2, would be enough. I have a proper internet connection for setting up virtual machine only in the Sunday evening. I’ll do final tests then.

bollwyvl · 2020-01-11T13:34:59Z

Looks like win could import cv2, but I should go ahead and move that test to the conda package build rather than wait for the atest, haven't had the chance to look at logs. No idea what to do about osx yet, might have been flake? I have no way to test that os until at least Monday, if then. Great timing, right? There may be some quick wins if we can get rid of qt by depending on matplotlib-base, but I don't see how that would help the osx issue.

…

On Sat, Jan 11, 2020, 01:32 Asko Soukka ***@***.***> wrote: Thanks. Anything that successfully imports cv2, would be enough. I have a proper internet connection for setting up virtual machine only in the Sunday evening. I’ll do final tests then. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#63?email_source=notifications&email_token=AAALCREDDDD54VNXGKWOAVDQ5FRXPA5CNFSM4KFPZVPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIV223A#issuecomment-573287788>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAALCRD57BCXBOF3JTBC6C3Q5FRXPANCNFSM4KFPZVPA> .

datakurre · 2020-01-11T13:37:39Z

I can test OSX on Sunday even. The drafted release did work on OSX.

bollwyvl · 2020-01-11T13:48:35Z

Does open CV work on that one? Is just hard to tell, since we weren't testing it... Perhaps I need a separate or of just the cli/nb tests, and not the resolving.

…

On Sat, Jan 11, 2020, 08:37 Asko Soukka ***@***.***> wrote: I can test OSX on Sunday even. The drafted release did work on OSX. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#63?email_source=notifications&email_token=AAALCRBTLJEVQ5TUTVRAYEDQ5HDSHA5CNFSM4KFPZVPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWCETQ#issuecomment-573317710>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAALCRGS7423WH6TTSJLXOLQ5HDSHANCNFSM4KFPZVPA> .

datakurre · 2020-01-11T14:38:15Z

Yes, the OpenCV example worked on OSX and has been working on Windows too (I just have not tested the last build).

Did you have time to try the draft Linux installer if it worked?

My Linux test on NixOS could have been false negative and I can only get working VM on Sunday evening.

bollwyvl · 2020-01-11T18:09:19Z

Trying released assets inside clean vagrant boxes...

…

On Sat, Jan 11, 2020 at 9:38 AM Asko Soukka ***@***.***> wrote: Yes, the OpenCV example worked on OSX and has been working on Windows too (I just have not tested the last build). Did you have time to try the draft Linux installer if it worked? My Linux test on NixOS could have been false negative and I can only get working VM on Sunday evening. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#63?email_source=notifications&email_token=AAALCRCDPPEHFEHO7KY6P7TQ5HKVRA5CNFSM4KFPZVPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWDI3A#issuecomment-573322348>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAALCRA3QIWN2STSXEMSYJ3Q5HKVRANCNFSM4KFPZVPA> .

bollwyvl · 2020-01-11T18:16:01Z

Vagrant.configure("2") do |config|
  config.vm.box = "ubuntu/bionic64"
  config.vm.provider "virtualbox" do |v|
    v.memory = 2048
    v.cpus = 2
  end
  config.vm.provision "shell", inline: "apt-get update"
  config.vm.provision "shell", inline: "apt-get install -y xfce4 virtualbox-guest-dkms virtualbox-guest-utils virtualbox-guest-x11"
  config.vm.provision "shell", inline: "sed -i 's/allowed_users=.*$/allowed_users=anybody/' /etc/X11/Xwrapper.config"
  config.vm.provision "file", source: "RobotLab-2020.01.0-Linux-x86_64.sh", destination: "RobotLab-2020.01.0-Linux-x86_64.sh"
  config.vm.provision "shell", inline: "bash RobotLab-2020.01.0-Linux-x86_64.sh -fbp ~/robotlab", privileged: false
end

bollwyvl · 2020-01-11T18:44:40Z

Can confirm cv2 does not import on linux box. It looks like the name of the package changed at some point to py-opencv.

bollwyvl · 2020-01-11T18:58:22Z

It also seems not particularly possible to install py-opencv against what's in the installer.

datakurre · 2020-01-11T19:05:47Z

@bollwyvl Thanks for confirming the issue. I did not bother you for nothing. Weird it still works for Windows and OSX.

Btw, OSX test did flicker for me on Friday. Just triggered build again and it passed.

bollwyvl · 2020-01-11T19:09:43Z

Rad. I'll keep banging on this today.

datakurre · 2020-01-11T19:13:45Z

Could you check these versions? I have added in notes that 2020.01.0 has version

opencv-3.4.1-py36h6fd60c2_1.tar.bz2

But 2019.12.0 has version

opencv-3.4.2-py36h6fd60c2_1.tar.bz2

That’s curious.

datakurre · 2020-01-11T19:15:57Z

Anyway, maybe this could be fixed by just finding opencv version that includes Python bindings for all platforms. Linux missing cv2 may be just packaging error 🤔

bollwyvl · 2020-01-11T19:19:08Z

Yeah, I think adding matplotlib did some things to the final resolution.

bollwyvl · 2020-01-11T19:32:32Z

Ick: osx couldn't find the right FF during the build...

bollwyvl · 2020-01-12T03:27:49Z

Ok, all the OSX failures are now due to headlessfirefox... in the robotlab tests, we're having to do

Create WebDriver    Firefox    executable_path=${geckodriver}    firefox_binary=${firefox}

I'm thinking that patching the notebook on packaging will be the most robust solution, but it's going to take a sec.

The windows fail looks like simple flake.

bollwyvl · 2020-01-12T03:47:12Z

recipes/robotlab/builder.py

 }
 SVG = SRC_DIR / "robotlab" / "src" / "robotlab" / "icons" / "starter.svg"

+OPENCV_OSX = """


Not prod of this: any thoughts of ways to make it cleaner? Can we add something at the RFSL layer?

bollwyvl · 2020-01-12T03:47:23Z

recipes/robotlab/builder.py

+                if line.startswith("Open Browser"):
+                    lines[i] = OPENCV_OSX
+
+    opencv.write_text(json.dumps(nb, indent=2))


datakurre · 2020-01-12T06:22:40Z

I am ok with search and replacing headlessfirefox with firefox if that helps for now.

bollwyvl · 2020-01-12T06:31:19Z

nah, there's hardcoded stuff to look for it in like Applications/FireFox.app/Contents/Blah/Blah i think... thing is it actually started it, but then crapped out in some opencv stuff.

…

On Sun, Jan 12, 2020 at 1:22 AM Asko Soukka ***@***.***> wrote: I am ok with search and replacing headlessfirefox with firefox if that helps for now. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#63?email_source=notifications&email_token=AAALCRBS7JHHLMYAUEUL2ZTQ5KZLDA5CNFSM4KFPZVPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWS6BI#issuecomment-573386501>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAALCRG5IJF7JA7I5AQSEXLQ5KZLDANCNFSM4KFPZVPA> .

bollwyvl · 2020-01-12T06:41:32Z

C'mon windows, no ❄️

bollwyvl · 2020-01-12T07:45:34Z

😆

datakurre · 2020-01-12T07:57:41Z

No sleep? 🙃

I’ll try these out in 12 hours.

datakurre · 2020-01-12T18:33:04Z

MacOS
Linux
Windows

datakurre · 2020-01-12T18:42:12Z

What is the correct way to activate the env in Linux and MacOS.

source bin/activate

?

bollwyvl · 2020-01-12T19:44:05Z

Yeah that's what we do generally...

…

On Sun, Jan 12, 2020, 13:42 Asko Soukka ***@***.***> wrote: What is the correct way to activate the env in Linux and MacOS. source bin/activate ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#63?email_source=notifications&email_token=AAALCRGXWIKWCMJT3DZOGZ3Q5NQAJA5CNFSM4KFPZVPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIXBD7Y#issuecomment-573444607>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAALCRBRDFLIHKEK4K4SMHLQ5NQAJANCNFSM4KFPZVPA> .

datakurre · 2020-01-12T19:50:43Z

That was quite a patch you had to do for OSX on OpenCV demo, and those patched notebooks ended up in the final distribution. It's ok for now, but need to think about those. I'd feel better to have simpler test notebooks separately for selenium and OpenCV in RobotLab instead of trying to execute everything crazy I dump into robotkernel examples :-)

datakurre · 2020-01-12T19:54:44Z

I learned the way to test Linux-installer on top of NixOS. OpenCV works.

Once again you saved the day!

datakurre · 2020-01-12T20:06:35Z

All green. Going to merge and relabel "More on robotkernel"-starter. And then move v2020.01.0 tag.

bollwyvl · 2020-01-12T20:09:21Z

Agreed, too crazy, but presumably would be required to work for a robotlab user on osx that didn't have ff already. But the more we can test, the less we have to manually test... Or in my case with osx, the only way I care to test. It's one of the key stories I tell people about this project. I could see offering a Library that did some of these dirty tricks. But wanted to get something working first. ***Settings*** Library SeleniumLibrary Library robotlab.FirefoxAsHeadlessFirefox Open browser http://Google.com browser=headlessfirefox And just do a savage hack of selenium to do our bidding. Wouldn't want it to be automatic, though.

…

On Sun, Jan 12, 2020, 14:54 Asko Soukka ***@***.***> wrote: I learned the way to test Linux-installer on top of NixOS. OpenCV works. Once again you saved the day! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#63?email_source=notifications&email_token=AAALCRCMU7FVHGRZVBVUGK3Q5NYQJA5CNFSM4KFPZVPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIXCUYY#issuecomment-573450851>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAALCRH2MB7ZE6V2N6HA2Q3Q5NYQJANCNFSM4KFPZVPA> .

bollwyvl · 2020-01-12T20:09:51Z

Hooray!

…

On Sun, Jan 12, 2020, 15:09 Asko Soukka ***@***.***> wrote: Merged #63 <#63> into master. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#63?email_source=notifications&email_token=AAALCRFB4CO7NEFUAX3ME2LQ5N2GDA5CNFSM4KFPZVPKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOV5JUO5I#event-2941470581>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAALCRDM7K6J6R2IUFNED7LQ5N2GDANCNFSM4KFPZVPA> .

datakurre · 2020-01-12T20:12:51Z

Needless to say I do appreciate a lot your effort and all the tests! There is your name and picture on the slides :-) https://github.com/robots-from-jupyter/robotkernel/blob/master/docs/robocon2020/index.ipynb This time I've prepared them with Notebook + RISE.

datakurre · 2020-01-13T04:29:20Z

Tested and released. Thanks again! (Windows tests did flicker once.)

bollwyvl · 2020-01-13T11:40:09Z

With _hours_ to spare!

…

On Sun, Jan 12, 2020, 23:29 Asko Soukka ***@***.***> wrote: Tested and released. Thanks again! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#63?email_source=notifications&email_token=AAALCRCBRXJG47ZKZ7CAHULQ5PU2BA5CNFSM4KFPZVPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIXPSNA#issuecomment-573503796>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAALCRC7SYLLF7QC5QOBRALQ5PU2BANCNFSM4KFPZVPA> .

datakurre · 2020-01-13T13:54:21Z

Hours... and a day! The workshop is only in 21 hours.

…

On 13. Jan 2020, 13.40 +0200, Nicholas Bollweg ***@***.***>, wrote: With _hours_ to spare! On Sun, Jan 12, 2020, 23:29 Asko Soukka ***@***.***> wrote: > Tested and released. Thanks again! > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#63?email_source=notifications&email_token=AAALCRCBRXJG47ZKZ7CAHULQ5PU2BA5CNFSM4KFPZVPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIXPSNA#issuecomment-573503796>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAALCRC7SYLLF7QC5QOBRALQ5PU2BANCNFSM4KFPZVPA> > . > — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.

bollwyvl · 2020-01-13T13:55:45Z

Heck, then what was I even worried about! But it's still great we got it out there. On Mon, Jan 13, 2020 at 8:54 AM Asko Soukka <[email protected]> wrote:

…

Hours... and a day! The workshop is only in 21 hours. On 13. Jan 2020, 13.40 +0200, Nicholas Bollweg ***@***.***>, wrote: > With _hours_ to spare! > > On Sun, Jan 12, 2020, 23:29 Asko Soukka ***@***.***> wrote: > > > Tested and released. Thanks again! > > > > — > > You are receiving this because you were mentioned. > > Reply to this email directly, view it on GitHub > > < #63?email_source=notifications&email_token=AAALCRCBRXJG47ZKZ7CAHULQ5PU2BA5CNFSM4KFPZVPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIXPSNA#issuecomment-573503796 >, > > or unsubscribe > > < https://github.com/notifications/unsubscribe-auth/AAALCRC7SYLLF7QC5QOBRALQ5PU2BANCNFSM4KFPZVPA > > > . > > > — > You are receiving this because you modified the open/close state. > Reply to this email directly, view it on GitHub, or unsubscribe. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#63?email_source=notifications&email_token=AAALCRFK6FCSGRTKNSS53PLQ5RXA5A5CNFSM4KFPZVPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIYZBGI#issuecomment-573673625>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAALCRHUNE752RAWUXIIUWDQ5RXA5ANCNFSM4KFPZVPA> .

datakurre · 2020-01-13T14:45:24Z

It is. Now I can have a good night sleep before (or try out what's broken in the latest RF 3.2 beta). And I did share the download links with the participants already in the morning.

bollwyvl added 7 commits January 10, 2020 22:26

first steps at testing as-installed opencv

fff8601

fix example test doc

592c872

try forcing qt version

781086d

more screenshots during example test

598a227

add py-opencv to robotlab recipe, more work on opencv example test

752d11c

go conda-forge forward, more work on example tests

6e33ac4

copy opencv file, clean up other examples

66249dd

more tinkering on cv/qt

93fdda4

test opencv during conda-build test of robotlab

9c45e50

skip the opencv test during conda build on osx: PATH?

0def51c

bollwyvl added 2 commits January 11, 2020 14:51

wuks splash for windows

9f7a5f5

back to anaconda for build stack

fcec90d

hack osx ff/gd paths, restore osx opencv test during conda build

6675acc

bollwyvl commented Jan 12, 2020

View reviewed changes

bollwyvl added 5 commits January 11, 2020 23:06

fix opencv browser line detection

f65d956

check browser line with regex

c9aee9a

create webdriver doesn't take headless

274bdbb

executable is geckodriver, firefox is firefox

fcbdfdb

skip opencv test during conda build, see if we get better output

29324b2

add ludicrous timeout for example

4de7e39

datakurre merged commit cf644e8 into robots-from-jupyter:master Jan 12, 2020

first steps at testing as-installed opencv #63

first steps at testing as-installed opencv #63

Uh oh!

Conversation

bollwyvl commented Jan 11, 2020

Uh oh!

datakurre commented Jan 11, 2020

Uh oh!

bollwyvl commented Jan 11, 2020 via email

Uh oh!

datakurre commented Jan 11, 2020

Uh oh!

bollwyvl commented Jan 11, 2020 via email

Uh oh!

datakurre commented Jan 11, 2020

Uh oh!

bollwyvl commented Jan 11, 2020 via email

Uh oh!

bollwyvl commented Jan 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bollwyvl commented Jan 11, 2020

Uh oh!

bollwyvl commented Jan 11, 2020

Uh oh!

datakurre commented Jan 11, 2020

Uh oh!

bollwyvl commented Jan 11, 2020 via email

Uh oh!

datakurre commented Jan 11, 2020

Uh oh!

datakurre commented Jan 11, 2020

Uh oh!

bollwyvl commented Jan 11, 2020

Uh oh!

bollwyvl commented Jan 11, 2020

Uh oh!

bollwyvl commented Jan 12, 2020

Uh oh!

bollwyvl Jan 12, 2020

Choose a reason for hiding this comment

Uh oh!

bollwyvl Jan 12, 2020

Choose a reason for hiding this comment

Uh oh!

datakurre commented Jan 12, 2020

Uh oh!

bollwyvl commented Jan 12, 2020 via email

Uh oh!

bollwyvl commented Jan 12, 2020

Uh oh!

bollwyvl commented Jan 12, 2020

Uh oh!

datakurre commented Jan 12, 2020

Uh oh!

datakurre commented Jan 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

datakurre commented Jan 12, 2020

Uh oh!

bollwyvl commented Jan 12, 2020 via email

Uh oh!

datakurre commented Jan 12, 2020

Uh oh!

datakurre commented Jan 12, 2020

Uh oh!

datakurre commented Jan 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bollwyvl commented Jan 12, 2020 via email

Uh oh!

bollwyvl commented Jan 12, 2020 via email

Uh oh!

datakurre commented Jan 12, 2020

Uh oh!

datakurre commented Jan 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bollwyvl commented Jan 13, 2020 via email

Uh oh!

bollwyvl commented Jan 11, 2020 •

edited

Loading

datakurre commented Jan 12, 2020 •

edited

Loading

datakurre commented Jan 12, 2020 •

edited

Loading

datakurre commented Jan 13, 2020 •

edited

Loading