Feature/qt4 qt5 #177
Feature/qt4 qt5 #177
Conversation
Semms like having Q_PLUGIN_METADATA(IID "QtPluginVizkitBase") is required to be in a header in Qt5
| cmake_policy(SET CMP0057 NEW) | ||
|
|
||
| find_package(Rock) | ||
| rock_init(base 1.0) |
There was a problem hiding this comment.
I think passing arguments to rock_init() is deprecated
There was a problem hiding this comment.
Sure, but lets not add that change on top as well.
| SonarVisualization.cpp | ||
| PointcloudVisualization.cpp | ||
| DepthMapVisualization.cpp | ||
| OrientedBoundingBoxVisualization.cpp |
There was a problem hiding this comment.
Should adding OrientedBoundingBoxVisualization be a separate PR? (I don't see anything wrong with that addition, i.e., I'd be fine with adding it here as well -- and this seems to have been in the qt4/qt5 branch for quite a while now ...)
There was a problem hiding this comment.
Its hard to get it out of the history at this point; a revert would potentially remove it again depending on merge order.
|
"Minor" Addendum: Building with |
Thanks for the heads-up, i did not think there would be viz-tests outside of test/viz(where only ruby tests live that cannot work without qtbindings for qt5) |
Especially fixes the not-building and failing when qt4 is not available.
This has the (surprisingly) fairly small bit converting base-types visualizations over to support qt5 besides qt4 and the addition of a OrientedBoundingBoxVisualization by Steffen.