Skip to content

Conversation

ldmi3i
Copy link
Collaborator

@ldmi3i ldmi3i commented Aug 14, 2022

Description

Adds:
Parsing functionality of the Open API 3.0 version.
File loading with checking the file size limits.
Updates of the API spec document.
Md5 hash of the file to the ASD model - to check is ASD updated (from storage and update service)

Closes #5
Closes #13

Current status

  • Waiting for review
  • Waiting for comment resolution
  • Waiting for merge
  • Draft

Semantic Versioning

  • This is a feat change

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Automated

Add unit tests with checks on the most critical parsing functionality.

Manual

Manually tested full-service logic i.e. loading, parsing, and posting the result of the parsing of the Trello Open API file.
https://developer.atlassian.com/cloud/trello/swagger.v3.json

The file size limit was tested using the link to the ubuntu image
https://releases.ubuntu.com/22.04.1/ubuntu-22.04.1-desktop-amd64.iso?_ga=2.69618068.564006705.1660983164-1991351496.1660983164

All completed right.

Checklist:

  • My commit message mentions fix, feat, BREAKING CHANGE accordingly to increase the semantic versioning
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have checked my code/docs and corrected any misspellings

@ldmi3i ldmi3i force-pushed the feature/parse_yml branch from 35dc18c to c54429e Compare August 14, 2022 11:45
@ldmi3i ldmi3i force-pushed the feature/parse_yml branch from 22dbb74 to 1ee295e Compare August 18, 2022 19:48
@ldmi3i ldmi3i force-pushed the feature/parse_yml branch from 1ee295e to be3bba4 Compare August 18, 2022 19:49
@ldmi3i ldmi3i force-pushed the feature/parse_yml branch from 34b21d0 to 70dc4dc Compare August 20, 2022 09:27
@ldmi3i ldmi3i marked this pull request as ready for review August 22, 2022 07:01
@ldmi3i ldmi3i added the review required The pull request is ready and needs to be reviewed or just requesting view from the outside. label Aug 22, 2022
@ldmi3i ldmi3i merged commit 36a91a5 into main Aug 23, 2022
@ldmi3i ldmi3i deleted the feature/parse_yml branch August 23, 2022 16:41
@github-actions
Copy link

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released review required The pull request is ready and needs to be reviewed or just requesting view from the outside.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Parser interface for the swagger JSON file. Implement Parser interface for the swagger YAML file.
1 participant