Skip to content

Try to completely remove identifiers that are namespace in the GMI #10969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Try to completely remove identifiers that are namespace in the GMI #10969

wants to merge 1 commit into from

Conversation

junaire
Copy link
Contributor

@junaire junaire commented Jul 15, 2022

This patch is to verify if we really need to store identifiers that
are namespace in GlobalModuleIndex, which greatly increase the maximum
memory pressure. Send this to trigger ROOT's CI so we can have a full
test, and will be closed if the direction is wrong.

No need for code review or merge

Signed-off-by: Jun Zhang [email protected]

@junaire
Try to completely remove identifiers that are namespace in the GMI
1ffc914 
This patch is to verify if we really need to store identifiers that
are namespace in GlobalModuleIndex, which greatly increase the maximum
memory pressure. Send this to trigger ROOT's CI so we can have a full
test, and will be closed if the direction is wrong.
No need for code review or merge.

Signed-off-by: Jun Zhang <[email protected]>
@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-07-15T14:55:06.055Z] 773/2390 Test Fixed TGeoPGon::GetPhiCrossList for point on the Z axis. #484: tutorial-dataframe-df014_CSVDataSource ............................................................***Failed Error regular expression found in output. Regex=[: error:] 0.32 sec
  • [2022-07-15T14:55:06.055Z] 774/2390 Test Improvements and new interfaces in KahanSum #485: tutorial-dataframe-df015_LazyDataSource ...........................................................***Failed Error regular expression found in output. Regex=[: error:] 0.32 sec
  • [2022-07-15T14:55:06.055Z] 775/2390 Test Faster default/copy construction of TObjects #482: tutorial-dataframe-df010_trivialDataSource ........................................................***Failed Error regular expression found in output. Regex=[: error:] 0.74 sec
  • [2022-07-15T14:55:07.781Z] 779/2390 Test Fixed TGeoPGon::GetPhiCrossList for point on the Z axis. #488: tutorial-dataframe-df018_customActions ............................................................***Failed Error regular expression found in output. Regex=[: error:] 1.68 sec
  • [2022-07-15T14:55:09.045Z] 783/2390 Test Fixes for 5 coverity defect reports #495: tutorial-dataframe-df025_RNode ....................................................................***Failed Error regular expression found in output. Regex=[: error:] 0.60 sec
  • [2022-07-15T14:55:09.045Z] 784/2390 Test [TMVA] Fix bug caught by testMinimizationCpu #492: tutorial-dataframe-df022_useKahan .................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.34 sec
  • [2022-07-15T14:55:09.724Z] 786/2390 Test Adjust all THttpServer source with travis  #496: tutorial-dataframe-df027_SQliteDependencyOverVersion ..............................................***Failed Error regular expression found in output. Regex=[: error:] 0.56 sec
  • [2022-07-15T14:55:09.724Z] 787/2390 Test Add VecCore external #497: tutorial-dataframe-df028_SQliteIPLocation .........................................................***Failed Error regular expression found in output. Regex=[: error:] 0.54 sec
  • [2022-07-15T14:55:10.007Z] 790/2390 Test Avoid double increment to loop variable #499: tutorial-dataframe-df030_SQliteVersionsOfROOT .....................................................***Failed Error regular expression found in output. Regex=[: error:] 0.35 sec
  • [2022-07-15T14:55:10.007Z] 791/2390 Test Use tolerance to compare floating point numbers in testGenVector.cxx #498: tutorial-dataframe-df029_SQlitePlatformDistribution ...............................................***Failed Error regular expression found in output. Regex=[: error:] 0.45 sec

And 11 more

Failing tests:

And 13 more

@phsft-bot
Copy link

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on mac11/cxx14.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2022-07-15T15:26:22.092Z] 585/2331 Test Vmc application update #461: tutorial-dataframe-df010_trivialDataSource ........................................................***Failed Error regular expression found in output. Regex=[: error:] 1.04 sec
  • [2022-07-15T15:26:24.132Z] 587/2331 Test A (fast) ApplyInverse() method for 3D affine transformations  #464: tutorial-dataframe-df014_CSVDataSource ............................................................***Failed Error regular expression found in output. Regex=[: error:] 0.53 sec
  • [2022-07-15T15:26:24.702Z] 588/2331 Test Cling -O2 with minimal inlining #465: tutorial-dataframe-df015_LazyDataSource ...........................................................***Failed Error regular expression found in output. Regex=[: error:] 0.54 sec
  • [2022-07-15T15:26:28.247Z] 591/2331 Test [TDF] Allow proper re-usage of TDataFrameValues #468: tutorial-dataframe-df018_customActions ............................................................***Failed Error regular expression found in output. Regex=[: error:] 2.38 sec
  • [2022-07-15T15:26:43.588Z] 595/2331 Test Keep clang-tidy modernize-use-bool-literals happy #472: tutorial-dataframe-df022_useKahan .................................................................***Failed Error regular expression found in output. Regex=[: error:] 3.04 sec
  • [2022-07-15T15:26:46.555Z] 598/2331 Test Moved TMath's fundamental constants to TMathBase #475: tutorial-dataframe-df025_RNode ....................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.11 sec
  • [2022-07-15T15:26:47.489Z] 599/2331 Test Proper check for destruction of global interface object #476: tutorial-dataframe-df027_SQliteDependencyOverVersion ..............................................***Failed Error regular expression found in output. Regex=[: error:] 1.06 sec
  • [2022-07-15T15:26:48.870Z] 600/2331 Test Added a modulemap for libc #477: tutorial-dataframe-df028_SQliteIPLocation .........................................................***Failed Error regular expression found in output. Regex=[: error:] 0.99 sec
  • [2022-07-15T15:26:49.700Z] 603/2331 Test [CLANG] Increase default value for -ftemplate-depth to 1024 #478: tutorial-dataframe-df029_SQlitePlatformDistribution ...............................................***Failed Error regular expression found in output. Regex=[: error:] 0.98 sec
  • [2022-07-15T15:26:50.266Z] 604/2331 Test [TDF] Comments and text fixes #479: tutorial-dataframe-df030_SQliteVersionsOfROOT .....................................................***Failed Error regular expression found in output. Regex=[: error:] 0.95 sec

And 11 more

Failing tests:

And 26 more

@phsft-bot
Copy link

Build failed on mac1015/cxx17.
Running on macitois22.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

And 3 more

@junaire
Copy link
Contributor Author

junaire commented Jul 16, 2022

So this change at least breaks when searching for nested namespaces, close it now...

Processing /data/sftnight/workspace/root-pullrequests-build/root/tutorials/dataframe/df014_CSVDataSource.C...
In file included from input_line_10:1:
/data/sftnight/workspace/root-pullrequests-build/root/tutorials/dataframe/df014_CSVDataSource.C:30:20: error: no member named 'RDF' in namespace 'ROOT'
   auto df = ROOT::RDF::MakeCsvDataFrame(fileName);
             ~~~~~~^
CMake Error at /data/sftnight/workspace/root-pullrequests-build/build/RootTestDriver.cmake:227 (message):
  error code: 1

@junaire junaire closed this Jul 16, 2022
@junaire junaire deleted the test-new-way branch July 16, 2022 01:28
@vgvassilev vgvassilev mentioned this pull request Jun 14, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junaire @phsft-bot