-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[llvm-project] Introduce paged vector [v6.30] #14411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[llvm-project] Introduce paged vector [v6.30] #14411
Conversation
The goal of the class is to be an (almost) drop in replacement for SmallVector and std::vector when those are presized and filled later, as it happens in SourceManager and ASTReader. By doing so, sparsely accessed PagedVector can profit from reduced memory footprint. Co-authored-by: Jonas Hahnfeld <[email protected]> (cherry picked from commit 9c7bac0)
Starting build on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Test Results 9 files 9 suites 1d 10h 28m 33s ⏱️ For more details on these failures, see this check. Results for commit 18014b8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. For me the PR is ready to be merged if it is confirmed that the failure on Windows is unrelated.
Yes, very likely the same as #14200 (comment) on |
Right, |
The goal of the class is to be an (almost) drop in replacement for SmallVector and std::vector when those are presized and filled later, as it happens in SourceManager and ASTReader.
By doing so, sparsely accessed PagedVector can profit from reduced memory footprint.
Co-authored-by: Jonas Hahnfeld [email protected]
(cherry picked from commit 9c7bac0, backport of #13808)