[runtime_cxxmodules] Fix '_FilesystemClock' build warning with macos 15.4 and mac-beta #18515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devajithvs
force-pushed
the
FilesystemClock.fix
branch
from
d470f59 to
58f80ab
Compare
|
Does this relate to: #16494 (see also the (many) comments) |
|
Oops, yes. Did not keep track of that. Thanks :) |
devajithvs
force-pushed
the
FilesystemClock.fix
branch
from
58f80ab to
2d0cbd9
Compare
Test Results 18 files 18 suites 4d 6h 22m 27s ⏱️ For more details on these failures, see this check. Results for commit 22a4948. ♻️ This comment has been updated with latest results. |
devajithvs
force-pushed
the
FilesystemClock.fix
branch
from
2d0cbd9 to
e58df92
Compare
hahnjo
reviewed
May 9, 2025
Including <chrono> first forces the private clock module to be imported
before <fstream> transitively includes <filesystem>
Fixes the warning:
```
[79/2727] Generating G__Core.cxx, ../lib/Core.pcm
In module 'std' imported from input_line_1:1:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.4.sdk/usr/include/c++/v1/__chrono/time_point.h:33:52: error: definition of '_FilesystemClock' must be imported from module 'std.std_private_chrono_file_clock' before it is required
template <class _Clock, class _Duration = typename _Clock::duration>
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.4.sdk/usr/include/c++/v1/__chrono/time_point.h:33:1: note: in instantiation of default argument for 'time_point<std::filesystem::_FilesystemClock>' required here
template <class _Clock, class _Duration = typename _Clock::duration>
^~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.4.sdk/usr/include/c++/v1/__chrono/file_clock.h:49:8: note: definition here is not reachable
struct _FilesystemClock {
```
devajithvs
force-pushed
the
FilesystemClock.fix
branch
from
e58df92 to
22a4948
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Including
chronofirst forces the private clock module to be imported beforefstreamtransitively includesfilesystemFixes the warning:
Upstream issue: llvm/llvm-project#138683
Changes or fixes:
Checklist:
This PR fixes #