Skip to content

[rfile] Introduce RFile first prototype #19958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[rfile] Introduce RFile first prototype #19958

wants to merge 5 commits into from

Conversation

silverweed
Copy link
Contributor

@silverweed silverweed commented Sep 23, 2025 •
edited
Loading

This PR adds a first version of the new RFile prototype, implementing basic Open/Append/Recreate/Get/Put methods.

For a sneak peek of the final shape of the prototype, see here

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@silverweed silverweed self-assigned this Sep 23, 2025
@silverweed silverweed requested a review from dpiparo as a code owner September 23, 2025 12:07
hageboeck
hageboeck reviewed Sep 23, 2025
View reviewed changes
Copy link
Member

@hageboeck hageboeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the work!

Seeing the code sparked a lot of questions. Many of those might be either addressed in later PRs and some might be irrelevant, so feel free to "Resolve" those.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2025 •
edited
Loading

Test Results

    20 files      20 suites   3d 13h 47m 27s ⏱️
 3 687 tests  3 687 ✅ 0 💤 0 ❌
72 254 runs  72 254 ✅ 0 💤 0 ❌

Results for commit 12db6b3.

♻️ This comment has been updated with latest results.

@silverweed silverweed force-pushed the rfile_01_1 branch 3 times, most recently from 978733c to 7430133 Compare September 24, 2025 11:41
hahnjo
hahnjo reviewed Sep 25, 2025
View reviewed changes
Copy link
Member

@hahnjo hahnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments, but in general I'll leave review to others...

@silverweed silverweed force-pushed the rfile_01_1 branch 2 times, most recently from 868ac3e to 6cbc229 Compare September 25, 2025 13:14
jblomer
jblomer reviewed Sep 28, 2025
View reviewed changes
Copy link
Contributor

@jblomer jblomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice take-off!

@silverweed silverweed requested a review from jblomer October 1, 2025 06:43
@silverweed silverweed force-pushed the rfile_01_1 branch 2 times, most recently from c6b3db0 to 850b471 Compare October 1, 2025 11:42
@silverweed silverweed force-pushed the rfile_01_1 branch 2 times, most recently from da895e4 to 51f718e Compare October 3, 2025 08:46
@silverweed silverweed requested a review from hahnjo October 3, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepadulano vepadulano Awaiting requested review from vepadulano

@enirolf enirolf Awaiting requested review from enirolf

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

@pcanal pcanal Awaiting requested review from pcanal pcanal is a code owner

@dpiparo dpiparo Awaiting requested review from dpiparo dpiparo is a code owner

@hageboeck hageboeck Awaiting requested review from hageboeck

@jblomer jblomer Awaiting requested review from jblomer

@hahnjo hahnjo Awaiting requested review from hahnjo

At least 1 approving review is required to merge this pull request.

Assignees

@silverweed silverweed

Labels
in:I/O
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@silverweed @jblomer @hahnjo @hageboeck