[CMake] Fix an RPath issue #20012
Draft
[CMake] Fix an RPath issue #20012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually, CMake automatically sets RUNPATH when target_link_libraries is used. However, since Core doesn't have other ROOT dependencies, its RUNPATH might only contain external dependencies or remain empty. To enable Core to find other ROOT libraries, its current location is added to its BUILD_RPATH.
Since ROOT libraries are generally next to libCore, one can use its location to shortcut library searches. The search order is now: ROOT_LIBRARY_PATH, Root.DynamicPath, LD_LIBRARY_PATH (or its equivalent), location of libCore, and then proceeding with ld loader paths. This allows users to override which libraries are loaded, and then proceeds with the currently loaded ROOT libraries, before going into the system.
To cover the gnuninstall case, switch mac beta and the linux arch-native builds to gnuinstall. This is done as an option override on special builds to not affect the binaries we produce.
Test Results 22 files 22 suites 3d 19h 2m 56s ⏱️ For more details on these failures, see this check. Results for commit 920940b. |
|
I have solved a similar problem in 47caba5 for TROOT, so |
guitargeek
reviewed
Sep 30, 2025
|
|
||
| ROOT_LINKER_LIBRARY(Core BUILTINS LZMA) | ||
|
|
||
| # This sets RUNPATH for libCore, which enables it to dlopen any ROOT library in its directory. |
There was a problem hiding this comment.
This is a very good addition in any case 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO