Skip to content

Conversation

siliataider
Copy link
Contributor

This Pull request:

Changes or fixes:

  • This PR integrates the UHI indexing test suite for ROOT histograms by adding Indexing1D, Indexing2D and Indexing3D test helpers specialized for ROOT.TH1 histograms.

  • For all tests to pass, a temporary equality patch (__eq__) for ROOT.TH1 within the test context is implemented checking histogram values instead of default object identity.

  • Since serialization is not yet implemented, the histograms are manually created and set in make_histogram.

Checklist:

  • tested changes locally

Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice thanks! I believe the test should also be added to the CMake bindings/pyroot/pythonizations/test/CMakeLists.txt so that it gets picked up by the CI

Copy link

github-actions bot commented Oct 1, 2025

Test Results

    22 files      22 suites   3d 21h 24m 19s ⏱️
 3 685 tests  3 685 ✅ 0 💤 0 ❌
79 174 runs  79 174 ✅ 0 💤 0 ❌

Results for commit b760fd0.

♻️ This comment has been updated with latest results.

Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free to merge once the CI is green

@siliataider siliataider merged commit 9b7193b into root-project:master Oct 3, 2025
158 of 165 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants