[ntuple] better error messages in field reconciliation #20023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 22 files 22 suites 3d 21h 1m 1s ⏱️ For more details on these failures, see this check. Results for commit 7d4b7f0. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
Oct 2, 2025
pcanal
approved these changes
Oct 2, 2025
|
Should we add a test for this? |
jblomer
force-pushed
the
ntuple-improve-reconciliation-err
branch
from
daddb67 to
97df930
Compare
hahnjo
approved these changes
Oct 6, 2025
jblomer
force-pushed
the
ntuple-improve-reconciliation-err
branch
from
97df930 to
83e7047
Compare
Use the type trace report to help identify the violating subfield in a field hiararchy.
jblomer
force-pushed
the
ntuple-improve-reconciliation-err
branch
from
83e7047 to
7d4b7f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When matching the in-memory field to the on-disk field fails, print a trace of the type hierarchy in-memory and on-disk that helps users to pinpoint the violating sub field.
Follow-up of #19937 (review)