Add missing ruby versions to CI file #504
Conversation
.github/workflows/ci.yml
Outdated
| @@ -30,6 +30,7 @@ jobs: | |||
| uses: ruby/setup-ruby@v1 | |||
| with: | |||
| bundler-cache: true | |||
| ruby-version: '3.2.2' | |||
There was a problem hiding this comment.
but this wasn't necessary before, right? why is it needed now?
There was a problem hiding this comment.
I think it's automatically set with the .ruby-version
There was a problem hiding this comment.
It's not needed, by default, it uses the .ruby-version
https://github.com/ruby/setup-ruby#single-job
There was a problem hiding this comment.
I think you're right: ruby-version: '3.2' # Not needed with a .ruby-version file
I had to put that becuase even though the ruby-version was set to 3.2 it was still using the last version in the CI.
Maybe it had to do with the cache 🤔
There was a problem hiding this comment.
I'll remove it from all places and check which version it's using
There was a problem hiding this comment.
hadn't refreshed, you are both right
guillermoap
force-pushed
the
add-missing-ruby-versions
branch
from
937caac to
6803ff8
Compare
On #444 I missed 2 places that needed the ruby version set