find Python debug interpreter on Windows #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirk Thomas <[email protected]>
dirk-thomas
force-pushed
the
dirk-thomas/fix-windows-debug-test
branch
from
a08ab21 to
79be16d
Compare
dirk-thomas
commented
Jul 7, 2020
| cmake_minimum_required(VERSION 3.5) | ||
|
|
||
| project(launch_testing_ament_cmake NONE) | ||
| project(launch_testing_ament_cmake) |
There was a problem hiding this comment.
This is necessary for FindPythonLibs to determine the Python libraries and include dirs.
|
CI builds testing
|
hidmic
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a test which has been failing on Windows debug since it was added in #236:
The same logic already happens in the CMake extra file of the package (
launch/launch_testing_ament_cmake/launch_testing_ament_cmake-extras.cmake
Lines 16 to 18 in a489de4
Windows debug build testing
launch_testing_ament_cmake: