Fix ComposableLifecycleNode autostart not using resolved name #481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce
fully_qualified_node_name
property toComposableNode
andNode
, so the property meaning discrepency ofnode_name
can be avoided.(
node_name
onNode
is the fully qualified node name, whilenode_name
for aComposableNode
was the plainnode_name
as needed forcomposition_interfaces/srv/LoadNode
)Fixes #479
Is this user-facing behavior change?
Did you use Generative AI?
No.
Additional Information
ComposableNode
looks like it could use a refactor, which could makelaunch_ros.actions.get_composable_node_load_request
a method of the class.Furthermore, I'm unsure of the need for the property redefinitions of
ComposableLifecycleNode
(such asnode_name
etc.).Since they are inherited as well.