Skip to content

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Dec 30, 2018

This corrects a lost git clone to https, we did this to remove warnings from rubygems etc, this brings the other repos inline with rspec-rails on this.

See:
rspec/rspec-core#2588
rspec/rspec-mocks#1254
rspec/rspec-expectations#1093
rspec/rspec-support#361

Note that: rspec/rspec-rails#2059 is open as to bring the appveyor.yml file in line.

Note this also adds the Ruby 2.6.0 update that has already been merged to repos.

Copy link
Member

@benoittgt benoittgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Jon. Thanks!

@JonRowe JonRowe merged commit ef97cc5 into master Dec 31, 2018
@JonRowe JonRowe deleted the switch-to-https branch December 31, 2018 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants