This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Update Cucumber #1439
Merged
Update Cucumber #1439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
force-pushed
the
update-cucumber
branch
from
1c4da3a to
7e05710
Compare
This was referenced Sep 5, 2021
pirj
force-pushed
the
update-cucumber
branch
3 times, most recently
from
18f0183 to
f3250c7
Compare
|
Removed everything unrelated to the version update. Green. |
cucumber 4.0.0 is not aware of breaking changes in diff-lcs 1.4.3, so excluding it cucumber 4.0.0 would run on Ruby 2.3, 2.4 and JRuby 9.1
pirj
force-pushed
the
update-cucumber
branch
from
247b211 to
5fb4a77
Compare
JonRowe
approved these changes
Sep 13, 2021
pirj
added a commit
to rspec/rspec-rails
that referenced
this pull request
Sep 18, 2021
cucumber 4.0.0 is not aware of breaking changes in diff-lcs 1.4.3, so excluding it cucumber 3.2 would run on Ruby 2.2, 2.3 and 2.4 Sibling PRs: - rspec/rspec-core#2877 - rspec/rspec-mocks#1439 - rspec/rspec-expectations#1320
pirj
added a commit
to rspec/rspec-rails
that referenced
this pull request
Sep 18, 2021
cucumber 4.0.0 is not aware of breaking changes in diff-lcs 1.4.3, so excluding it cucumber 3.2 would run on Ruby 2.2, 2.3 and 2.4 Sibling PRs: - rspec/rspec-core#2877 - rspec/rspec-mocks#1439 - rspec/rspec-expectations#1320
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.3-2.0 don't work for me locally with a weird error:
2.4.0 spits "undefined method
with_filtered_backtrace" in some other repository (rspec-coreto my best memory)3.2.0 - "undefined method
ok?" there as well4.1 depends on
diff-lcs (< 1.4, >= 1.3, ~> 1.3), while we depend on= 1.4.45.2.0 only supports Ruby > 2.5. we support >=2.3. But it depends on
diff-lcs>= 1.4.4.I've checked 3.2.0, 4.1.0, 5.3.0, 6.1.0, and they work (except for 4.1.0).
I vaguely recall we were discussing not running
cucumberon older Rubies (2.3-2.4), is this correct?Otherwise I'll roll back to 3.2.0.
Sibling PRs: