Set RAILS_ENV to test in rails_helper #1947
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a solution to tests running in development environment as stated in issues rspec#70 and rspec#586. Before Rails 3.2.7 ENV['RAILS_ENV'] ||= 'test' ran tests without issues in test env as discussed in rails/rails#7175 (comment).
|
I always make this change in my
This file is in my app, not in RSpec. |
|
The justification behind this is that it's a template, and this is the friendliest, safest option. Its perfectly ok to modify in your own projects, but it's not our recommended thing to do, thus closing. Thanks for taking the time to contribute :) |
|
It should at least be warned about its implications in the README. That caused my tests to run in development environment and the entire database was wiped out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a solution to tests running in development environment as stated in issues #70 and #586.
Before Rails 3.2.7,
ENV['RAILS_ENV'] ||= 'test'ran tests without issues in test env as discussed in rails/rails#7175 (comment).