Skip to content

Remove version-specific checks for unsupported Rails/Ruby #2614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 19, 2022
Merged

Remove version-specific checks for unsupported Rails/Ruby #2614

merged 5 commits into from
Jul 19, 2022

Conversation

pirj
Copy link
Member

@pirj pirj commented Jul 17, 2022

Changes:

  1. Remove version-specific checks for unsupported Rails/Ruby
  2. Simplify sqlite3 dependency
  3. Update Cucumber to always use 7.x and mute an annoying message
  4. Add "Upgrade to RSpec-Rails 6" section

pirj added 3 commits July 17, 2022 22:14
@pirj
Use the latest Cucumber
33702c0 
Originally:

> cucumber 3.2 would run on Ruby 2.2, 2.3 and 2.4

But Rails 6.1 and we only support Ruby 2.5+, so this is not needed.
@pirj
Mute annoying message
00e59fe 
┌──────────────────────────────────────────────────────────────────────────────┐
│ Share your Cucumber Report with your team at https://reports.cucumber.io     │
│ To disable this message, specify CUCUMBER_PUBLISH_QUIET=true or use the      │
...
│ --publish-quiet option. You can also add this to your cucumber.yml:          │
│ default: --publish-quiet                                                     │
└──────────────────────────────────────────────────────────────────────────────┘

Now we can. Previously, this would break as previous Cucumber versions
didn't know about this option flag.
@pirj
Simplify sqlite3 dependency
a67fb9d 
The comment still stands
https://github.com/rails/rails/blob/9994d38bc6c1a8662e510d26c0e9ca8c24ab1189/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L13
@pirj pirj self-assigned this Jul 17, 2022
@pirj pirj force-pushed the remove-some-hacks branch from 0616111 to f16f199 Compare July 17, 2022 20:45
@pirj pirj force-pushed the remove-some-hacks branch from f16f199 to 229f5f7 Compare July 17, 2022 21:18
@pirj pirj requested review from JonRowe and benoittgt July 17, 2022 21:18
@pirj pirj marked this pull request as ready for review July 17, 2022 21:19
@pirj pirj added this to the 6.0 milestone Jul 18, 2022
@pirj pirj mentioned this pull request Jul 18, 2022
Closed
21 tasks
@JonRowe JonRowe merged commit 8f449ab into main Jul 19, 2022
@JonRowe JonRowe deleted the remove-some-hacks branch July 19, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonRowe JonRowe JonRowe approved these changes

@benoittgt benoittgt Awaiting requested review from benoittgt

Assignees

@pirj pirj

Labels
None yet
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pirj @JonRowe