Remove empty lines from html #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 5, 2020
👍 How do you remove it, did you update |
|
Is this only needed for 2.14 and 2.99? |
|
So this is mostly new line removals (I had to diff manually and grep) but also adds some div closing tags and I'm not sure why. |
|
Sorry for the big commit. Feel free to make any remarks of my work. I am also here to constantly improve myself. Advices and suggestions are always welcome. 😊 It should have added commands to show additions and deletions in PR body. Here is the diff without empty lines and "Generated on..." timestamp $ git diff -U0 HEAD\~1..HEAD | \
grep -v '^@@ ' | \
grep -v '^-[[:blank:]]*$' | \
grep -B1 -E '^(-[^-]|\+[^+])[^ Generated on]'+++ b/source/documentation/3.0/rspec-core/RSpec/Core/Runner.html
-</div>
+</div>
--
+++ b/source/documentation/3.1/rspec-core/RSpec/Core/Runner.html
-</div>
+</div>
--
+++ b/source/documentation/3.2/rspec-core/RSpec/Core/Notifications/ExamplesNotification.html
-</div>
+</div>
--
+++ b/source/documentation/3.2/rspec-core/RSpec/Core/Runner.html
-</div>
+</div>
--
+++ b/source/documentation/3.3/rspec-core/RSpec/Core/Notifications/ExamplesNotification.html
-</div>
+</div>
--
+++ b/source/documentation/3.3/rspec-core/RSpec/Core/Runner.html
-</div>
+</div>
--
+++ b/source/documentation/3.4/rspec-core/RSpec/Core/Notifications/ExamplesNotification.html
-</div>
+</div>
--
+++ b/source/documentation/3.4/rspec-core/RSpec/Core/Runner.html
-</div>
+</div>
--
+++ b/source/documentation/3.5/rspec-core/RSpec/Core/Notifications/ExamplesNotification.html
-</div>
+</div>
--
+++ b/source/documentation/3.5/rspec-core/RSpec/Core/Runner.html
-</div>
+</div>
--
+++ b/source/documentation/3.6/rspec-core/RSpec/Core/Notifications/ExamplesNotification.html
-</div>
+</div>
--
+++ b/source/documentation/3.6/rspec-core/RSpec/Core/Runner.html
-</div>
+</div>
--
+++ b/source/documentation/3.7/rspec-core/RSpec/Core/Notifications/ExamplesNotification.html
-</div>
+</div>
--
+++ b/source/documentation/3.7/rspec-core/RSpec/Core/Runner.html
-</div>
+</div>
--
+++ b/source/documentation/3.8/rspec-core/RSpec/Core/Notifications/ExamplesNotification.html
-</div>
+</div>
--
+++ b/source/documentation/3.8/rspec-core/RSpec/Core/Runner.html
-</div>
+</div>
--
+++ b/source/documentation/3.9/rspec-core/RSpec/Core/Notifications/ExamplesNotification.html
-</div>
+</div>
--
+++ b/source/documentation/3.9/rspec-core/RSpec/Core/Runner.html
-</div>
+</div>So div are only moved. |
It is needed for every version. |
|
Oh its removing some spacing after the tags? Thats ok then. |
|
Yep @JonRowe :)
|
JonRowe
approved these changes
Apr 7, 2020
|
I'd suggest not merging until #138 is merged, then merge this into source, because it makes diffing 138 way more difficult. |
|
No problem Jon |
benoittgt
force-pushed
the
no-plugin-no-bash-command-from-source
branch
from
cd21fc5 to
201731d
Compare
|
The last change remove only blank lines: $ git diff -U0 HEAD\~1..HEAD | \
grep -v '^@@ ' | \
grep -v '^-[[:blank:]]*$' | \
grep -B1 -E '^(-[^-]|\+[^+])[^ Generated on]'+++ b/source/documentation/3.0/rspec-core/RSpec/Core/Runner.html
-</div>
+</div>
--
+++ b/source/documentation/3.1/rspec-core/RSpec/Core/Runner.html
-</div>
+</div>
--
+++ b/source/documentation/3.2/rspec-core/RSpec/Core/Notifications/ExamplesNotification.html
-</div>
+</div>
--
+++ b/source/documentation/3.2/rspec-core/RSpec/Core/Runner.html
-</div>
+</div>
--
+++ b/source/documentation/3.3/rspec-core/RSpec/Core/Notifications/ExamplesNotification.html
-</div>
+</div>
--
+++ b/source/documentation/3.3/rspec-core/RSpec/Core/Runner.html
-</div>
+</div>
--
+++ b/source/documentation/3.4/rspec-core/RSpec/Core/Notifications/ExamplesNotification.html
-</div>
+</div>
--
+++ b/source/documentation/3.4/rspec-core/RSpec/Core/Runner.html
-</div>
+</div>
--
+++ b/source/documentation/3.5/rspec-core/RSpec/Core/Notifications/ExamplesNotification.html
-</div>
+</div>
--
+++ b/source/documentation/3.5/rspec-core/RSpec/Core/Runner.html
-</div>
+</div>
--
+++ b/source/documentation/3.6/rspec-core/RSpec/Core/Notifications/ExamplesNotification.html
-</div>
+</div>
--
+++ b/source/documentation/3.6/rspec-core/RSpec/Core/Runner.html
-</div>
+</div>
--
+++ b/source/documentation/3.7/rspec-core/RSpec/Core/Notifications/ExamplesNotification.html
-</div>
+</div>
--
+++ b/source/documentation/3.7/rspec-core/RSpec/Core/Runner.html
-</div>
+</div>
--
+++ b/source/documentation/3.8/rspec-core/RSpec/Core/Notifications/ExamplesNotification.html
-</div>
+</div>
--
+++ b/source/documentation/3.8/rspec-core/RSpec/Core/Runner.html
-</div>
+</div>
--
+++ b/source/documentation/3.9/rspec-core/RSpec/Core/Notifications/ExamplesNotification.html
-</div>
+</div>
--
+++ b/source/documentation/3.9/rspec-core/RSpec/Core/Runner.html
-</div>
+</div> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rdoc/Erb generate a lot of extra empty lines. After a discussion #136 (review) and few try in RDoc and Erb the easiest solution at the moment is to remove line by ourself.
Dependent of #138