[WIP] Temporary fix for test-plot-coordmap.R test (Fixes #2169) #2184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersion of ggplot2 Originally caused by tidyverse/ggplot2#2832 Need to wait for tidyverse/ggplot2#2821 to be merged. Expecting a bug fix release between 3.0.0 and when this bug will be fixed, so can not compare against pkg versions. :-/
|
Looking at it with Winston, tidyverse/ggplot2#2821 will rename the coord-trans |
schloerke
changed the title
|
To be clear, we shouldn't merge this, as the fix for this problem will land on the ggplot2 master branch. This problem never existed with any CRAN version of ggplot2; we were seeing CI errors because we had Remotes:tidyverse/ggplot2 (which I've now removed). However, keeping this open to track the issue until the ggplot2 PR above is merged, then we can close this one. |
schloerke
changed the title
|
fixed in current ggplot2 github branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2169
Removed ggplot2 remote as it's not needed anymore.
Test now allows for different values of ggplot2 domain. THIS IS A DUCT TAPE FIX for the dev version of ggplot2.
Originally caused by tidyverse/ggplot2#2832
Need to wait for tidyverse/ggplot2#2821 to be merged.
Expecting a bug fix release between 3.0.0 and when this bug will be fixed, so can not compare against pkg versions. :-/