forked from GoogleForCreators/web-stories-wp
-
Notifications
You must be signed in to change notification settings - Fork 4
Adds 'Web Stories List' Block #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Pascal Birchler <[email protected]>
This needs rebase / merge. |
- Updates styled components for the story picker module for better alignment.
- Adds class on Web Stories block wrapper if it's an AMP request. - Removed 'glider-js' in favour of npm package for the same.
Merged
- Removes chunkSplitting for 'web-stories-scripts' due to issues with the bundle not loading, known issue with webpack v4.
Replaces custom Lightbox with `amp-lightbox` on AMP pages.
- Update: Comments and Component refactoring for the blocks.
- Removes redundant component structures.
- Updates web stories block to use pre defined fields state for default state of the different views. - Updates web stories block components to use field state, which is also an attribute for the block.
Local/refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the 'Web Stories List' Block, the block has options to switch between the following types:
Relevant Technical Choices
blockSwitcher
into the 'Web Stories' blocks' edit component we are using theeditor.BlockEdit
filter.Difference between view markup choices:
-- On non-AMP pages 'glider-js' is used to render the carousel.
-- On AMP pages it uses
amp-carousel
extension.Lightbox Effect:
div
is used with a singleamp-story-player
, adding stories as needed.div
with oneamp-story-player
for each story.To-do
amp-story-player
on AMP pages for the lightbox.User-facing changes
Adds a new 'Web Stories List' block that can embed web stories on pages/posts.
Testing Instructions
/web
and select the block.Fixes #78 #132 #79 #129 #131 #42 #133 #93 #38