Fix Does not compile using the latest nightly #7
#8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge latest changes
|
I think similar fixes are required for |
|
In the meanwhile, is there a workaround? |
|
@et1975 You can add my fork to your Cargo.toml as a git crate. I think you might have to use the second to last commit as the latest will not build locally. |
|
@Chocol4te thanks, had to tweak it, if anyone needs this. |
|
@japaric Can you merge this? |
|
@Chocol4te I've successfully used your version with the latest nightly, the necessary updates for |
|
@Chocol4te Thanks! bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 19, 2018
8: Fix `Does not compile using the latest nightly #7` r=japaric a=chocol4te I bumped dependencies and added new `proc-macro2` syntax. I don't think what I wrote is best practice though :( Fixes #7 Co-authored-by: Ferdia McKeogh <[email protected]> Co-authored-by: Jorge Aparicio <[email protected]>
Build succeeded |
bors bot
added a commit
to rtic-rs/rtic
that referenced
this pull request
Aug 24, 2018
80: Fix "Could not find `Op` in `proc_macro`" r=japaric a=chocol4te Fixes nightly error with `proc-macro2`. Should not be merged until rtic-rs/rtic-syntax#8 is merged and new `rtfm-syntax` version is published. Co-authored-by: Ferdia McKeogh <[email protected]> Co-authored-by: Jorge Aparicio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I bumped dependencies and added new
proc-macro2syntax. I don't think what I wrote is best practice though :(Fixes #7